Skip to content

Resolve "External statuses not shown correctly on pipeline page"

Mike Greiling requested to merge 24710-fix-generic-commit-status-table-row into master

What does this MR do?

Updates generic_commit_status/_generic_commit_status.html.haml template to match the changes made to ci/builds/_build.html.haml which had not previously been carried over.

Testing

  1. Ensure updated fixtures are installed (from !7792 (merged)) so that these changes are made apparent. (check out the !7792 (merged) branch if not yet merged into master, then bundle exec rake db:drop and bundle exec rake dev:setup)

  2. Visit a build list page or an individual pipeline page which contains an external build status.

  3. The results should look like this:

Before:

Screen_Shot_2016-11-28_at_9.11.27_PM

After:

Screen_Shot_2016-11-28_at_9.12.05_PM

Are there points in the code the reviewer needs to double check?

Look for any places where these partials may be rendered to ensure external status match regular build statuses.

Why was this MR needed?

The generic commit status template has been largely overlooked when changes are made to build table rows which should be duplicated in both places.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #24710 (closed)

Merge request reports