Resolve "External statuses not shown correctly on pipeline page"
What does this MR do?
Updates generic_commit_status/_generic_commit_status.html.haml
template to match the changes made to ci/builds/_build.html.haml
which had not previously been carried over.
Testing
-
Ensure updated fixtures are installed (from !7792 (merged)) so that these changes are made apparent. (check out the !7792 (merged) branch if not yet merged into master, then
bundle exec rake db:drop
andbundle exec rake dev:setup
) -
Visit a build list page or an individual pipeline page which contains an external build status.
-
The results should look like this:
Before:
After:
Are there points in the code the reviewer needs to double check?
Look for any places where these partials may be rendered to ensure external status match regular build statuses.
Why was this MR needed?
The generic commit status template has been largely overlooked when changes are made to build table rows which should be duplicated in both places.
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #24710 (closed)