Replace static fixture for right_sidebar_spec
What does this MR do?
Replace right_sidebar.html.haml
for right_sidebar_spec.js
by already existing dynamically generated fixture.
What are the relevant issue numbers?
Merge request reports
Activity
Added 1 commit:
- 8a39cd97 - Replace static fixture for right_sidebar_spec (!7687 (merged))
Mentioned in issue #24753 (closed)
@winniehell This looks great and I love these MR series. Thanks for working on this and making our tests more solid. You are great
@ClemMakesApps Could you also review this please?
Reassigned to @ClemMakesApps
Thanks @winniehell. Can you fix the merge conflicts? Otherwise, it LGTM. @fatihacet can you review?
Reassigned to @fatihacet
Added 236 commits:
-
8a39cd97...84638de6 - 235 commits from branch
gitlab-org:master
- bc1b305d - Replace static fixture for right_sidebar_spec (!7687 (merged))
-
8a39cd97...84638de6 - 235 commits from branch
Thank you @ClemMakesApps!
Conflicts are resolved now.@winniehell build failed
Reassigned to @winniehell
build failed
@fatihacet Thank you for letting me know!
(e-mail notification didn't work ) I have retried the failed builds and they pass now.Reassigned to @fatihacet
@winniehell This is great work! Thanks for doing this and thanks for the quick build fix
Mentioned in commit bc1b305d
Mentioned in commit 1646b81e
changed milestone to %8.15