Milestone dropdown does not stay selected
What does this MR do?
It resolve the regression when Upcoming
and No Milestone
is selected from Milestone dropdown in issue filter form
Are there points in the code the reviewer needs to double check?
May be not
Why was this MR needed?
This MR closes issue #23713 (closed) regression
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #23713 (closed)
Merge request reports
Activity
Marked the task CHANGELOG entry added as completed
Added 1 commit:
- fd739a60 - adds test for dropdown selected text for each context
Marked the task Documentation created/updated as completed
Marked the task Conform by the merge request performance guides as completed
Marked the task Conform by the merge request performance guides as incomplete
Marked the task Conform by the style guides as completed
Reassigned to @fatihacet
@nmrony Conflicts
💥 Reassigned to @nmrony
Added 73 commits:
-
fd739a60...e4990b8c - 72 commits from branch
master
- f7b36f53 - Merge branch 'master' into 23713-milestone-dropdown-not-selected
-
fd739a60...e4990b8c - 72 commits from branch
Marked the task Conform by the merge request performance guides as completed
Reassigned to @chriscool
Reassigned to @fatihacet
@fatihacet conflict is resolved ;)
Added 1 commit:
- 9122ad64 - resolves rubocop complaints for old hash syntax
Added 1 commit:
- 9122ad64 - resolves rubocop complaints for old hash syntax
- Resolved by Nur Rony
@fatihacet going to give this to @rspeicher to review.
@jschatz1 Sounds good to me. Assigned to @rspeicher.
Reassigned to @rspeicher
Milestone changed to %8.14
- Resolved by Nur Rony
@nmrony Couple things.
Reassigned to @nmrony
Added 1 commit:
- 7a5f792d - removes calling unnecessary escape function
Added 111 commits:
-
9122ad64...b216d9bf - 107 commits from branch
master
- 993453c5 - fixes milestone dropdown not select issue
- e95e9a40 - changelog entry added
- 1a7ebbe8 - adds merge request number
- 66dd9096 - adds test for milestone dropdown selected text
Toggle commit list-
9122ad64...b216d9bf - 107 commits from branch
Added 1 commit:
- 43559586 - adds changelog entry in 8.13.2 and removed redundant changelog sections
Marked the task Squashed related commits together as completed
Milestone changed to %8.13
Mentioned in issue #23827 (closed)
Reassigned to @fatihacet
Reassigned to @rspeicher
Added 34 commits:
-
305c2524...b328c788 - 33 commits from branch
master
- e45a9f5b - fixes milestone dropdown not select issue
-
305c2524...b328c788 - 33 commits from branch
Milestone changed to %8.14
Mentioned in issue #23101 (closed)
Mentioned in commit 1c491e54
@rspeicher Wrong milestone, too bad, it could have gone into 8.13.4 or 8.13.5! :(
Milestone changed to %8.13
Mentioned in issue #24326 (closed)
Mentioned in commit 52c7286a