Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !7093

Pass user instance to Labels::FindOrCreateService or skip_authorization: true

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adam Niedzielski requested to merge adam-fix-labels-find-or-create into master Oct 25, 2016
  • Overview 28
  • Commits 1
  • Pipelines 6
  • Changes 10

What does this MR do?

It fixes a bug described in #23694 (closed) when project.owner was passed to Labels::FindOrCreateService. Labels::FindOrCreateService expected a user instance and project.owner may return a group as well. This MR makes sure that we either pass a user instance or skip_authorization: true.

Are there points in the code the reviewer needs to double check?

  • places where we pass skip_authorization: true

Does this MR meet the acceptance criteria?

  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Fixes #23694 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: adam-fix-labels-find-or-create