Skip to content
Snippets Groups Projects

Account for fixed position MR when scrolling to elements

Account for fixed position MR when scrolling to elements
23520-mr-sticky-tabs-overlap-discussion-from-anchor into master
1 unresolved thread
Merged Luke Bennett requested to merge 23520-mr-sticky-tabs-overlap-discussion-from-anchor into master
1 unresolved thread

What does this MR do?

This MR accounts for the new merge request fixed affix bar when scrolling to an element on the MR page.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The fixed MR tabs bar was not being taken into account when shifting permalink scroll targets so that they are unobscured by navigation elements.

Screenshots (if relevant)

Issues discussion permalink: Screen_Shot_2016-10-26_at_12.29.26_AM

Merge request discussion permalink: Screen_Shot_2016-10-26_at_12.28.26_AM

Merge request diff permalink: Screen_Shot_2016-10-26_at_12.29.02_AM

Commit diff page permalinks work as well, but aren't highlighted currently (see: #23696 (closed))

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #23520 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luke Bennett Assignee removed

    Assignee removed

  • Luke Bennett Reassigned to @lbennett

    Reassigned to @lbennett

  • Luke Bennett Resolved all discussions

    Resolved all discussions

  • Luke Bennett Added 1 commit:

    Added 1 commit:

    • 97e7f3ef - Account for merge request fixed affix bar

    Compare with previous version

  • Luke Bennett Added 1 commit:

    Added 1 commit:

    • 97e7f3ef - Account for merge request fixed affix bar

    Compare with previous version

  • Mike Greiling Mentioned in issue #23759 (closed)

    Mentioned in issue #23759 (closed)

  • Mike Greiling Reassigned to @fatihacet

    Reassigned to @fatihacet

  • Mike Greiling Mentioned in issue #22781 (closed)

    Mentioned in issue #22781 (closed)

  • Rémy Coutable
    Rémy Coutable @rymai ·
    Maintainer

    @lbennett Please consider assigning to someone else if @fatihacet is not available to review this! ;)

  • Rémy Coutable Added ~17876 label

    Added ~17876 label

  • Fatih Acet
    Fatih Acet @fatihacet ·
    Contributor

    @lbennett Conflicts :boom:

  • Fatih Acet Reassigned to @lbennett

    Reassigned to @lbennett

  • Winnie Mentioned in merge request !7318 (merged)

    Mentioned in merge request !7318 (merged)

  • Luke Bennett Added 514 commits:

    Added 514 commits:

    Compare with previous version

  • Luke Bennett Reassigned to @fatihacet

    Reassigned to @fatihacet

  • Fatih Acet
    Fatih Acet @fatihacet ·
    Contributor

    Tested this works good Thanks @lbennett :thumbsup:

  • Fatih Acet Status changed to merged

    Status changed to merged

  • Fatih Acet Mentioned in commit 41899c2a

    Mentioned in commit 41899c2a

  • Rémy Coutable Mentioned in issue #24326 (closed)

    Mentioned in issue #24326 (closed)

  • Rémy Coutable
    Rémy Coutable @rymai ·
    Maintainer

    Picked into 8-13-stable, will go into 8.13.6.

  • Rémy Coutable Removed ~149423 label

    Removed ~149423 label

  • Fatih Acet Mentioned in commit b4db3888

    Mentioned in commit b4db3888

  • Winnie
    Winnie @winniehell started a thread on the diff
    • app/assets/javascripts/application.js
    58 58 document.addEventListener('page:fetch', gl.utils.cleanupBeforeFetch);
    59 59 window.addEventListener('hashchange', gl.utils.shiftWindow);
  • Winnie Resolved all discussions

    Resolved all discussions

  • Fatih Acet mentioned in commit ff23636c

    mentioned in commit ff23636c

  • Fatih Acet mentioned in commit 460f6527

    mentioned in commit 460f6527

    • Please register or sign in to reply