Guests can read builds if those are public
Guests were not able to read builds/pipelines but we claimed in the docs this was possible.
However, the build details will remain hidden for guests
Merge request reports
Activity
Added 1 commit:
- d216792e - Guests can read builds if those are public
Added 1 commit:
- 56d2fe33 - Guests can read builds if those are public
@brodock This has been stale for 5 days already, could you review or reassign to someone else?
- Resolved by Zeger-Jan van de Weg
@zj I've left some comments on the MR :)
When public pipelines are disable, I can still access the "pipelines page" but nothing is clickable there. Is this the expected behavior?
@markpundsack What do you think? IMO this is a well spotted bug by @brodock, but on the projects page we do show what the status is? I think we have show an access denied here, would you agree?
Mentioned in issue #18448 (closed)
Any news about this? @zj
@yongkangchen I pinged @markpundsack on Slack, hopefully I can get an answer soon. :)
Reassigned to @zj
@zj Thanks very much
@zj I’m not sure I really understand the underlying question. What’s your recommendation? Are you suggesting we should keep show the pipeline graph, but when someone clicks on a build, show a 404? That seems inconsistent.
I can see the value in seeing the pipeline graph, but then I have to question why we're blocking the build detail page, and if it's just because the build logs may disclose sensitive information, then perhaps we should just hide that information, but still show meta information about the build. At least that wouldn't be consistent, but that also feels like a bigger change.
So, going the other way, unless we want to introdue finer permissoins, it makes sense that if you've disabled public builds, that you're disabling public view of any portion of pipelines.
@zj Can you clarify what this MR actually does in the description?
Milestone changed to %8.15
Added 3053 commits:
-
56d2fe33...8fad76b6 - 3052 commits from branch
master
- a74e5332 - Guests can read builds if those are public
-
56d2fe33...8fad76b6 - 3052 commits from branch
@brodock So this was expected behaviour. And on second thought rightfully so. Could you elaborate on you comment on the tests? Than I can move this forward and get it in 8.15
😄 Reassigned to @brodock
Added 83 commits:
-
a74e5332...35e6c2ba - 81 commits from branch
master
- 743078c6 - Guests can read builds if those are public
- 441f172f - Update effected tests
-
a74e5332...35e6c2ba - 81 commits from branch
- Resolved by Zeger-Jan van de Weg
Reassigned to @zj
@zj just one thing more to fix, and you can send to the endboss. Good job :)
Reassigned to @brodock
@zj changes looks good
👍🏻 , please send to the endboss.Reassigned to @zj
Reassigned to @smcgivern
- Resolved by Zeger-Jan van de Weg
@zj I just have a nitpick in the spec, otherwise this looks good!
Reassigned to @zj
Reassigned to @smcgivern
- Resolved by Zeger-Jan van de Weg
enabled an automatic merge when the build for 8f174170 succeeds
added 271 commits
-
8f174170...bd674591 - 269 commits from branch
master
- 617f43c7 - Guests can read builds if those are public
- aabee059 - Update effected tests
-
8f174170...bd674591 - 269 commits from branch
@smcgivern Could you take a look today? This should be ready.
Last time it failed as the merge base had a failing test.
mentioned in commit 0ff8f002
@zj thanks, merged!
💯 Edited by Sean McGivernmentioned in merge request !8711 (merged)
mentioned in issue #34708 (closed)