Skip to content
Snippets Groups Projects

Guests can read builds if those are public

Merged Zeger-Jan van de Weg requested to merge zj-guest-reads-public-builds into master
All threads resolved!

Guests were not able to read builds/pipelines but we claimed in the docs this was possible.

However, the build details will remain hidden for guests

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • When public pipelines are disable, I can still access the "pipelines page" but nothing is clickable there. Is this the expected behavior?

    non_public_pipelines

  • There is a merge conflict (probably related to the CHANGELOG). Code looks good.

  • @zj I've left some comments on the MR :)

  • When public pipelines are disable, I can still access the "pipelines page" but nothing is clickable there. Is this the expected behavior?

    @markpundsack What do you think? IMO this is a well spotted bug by @brodock, but on the projects page we do show what the status is? I think we have show an access denied here, would you agree?

  • Mentioned in issue #18448 (closed)

  • Any news about this? @zj

  • @yongkangchen I pinged @markpundsack on Slack, hopefully I can get an answer soon. :)

  • Reassigned to @zj

  • @zj I’m not sure I really understand the underlying question. What’s your recommendation? Are you suggesting we should keep show the pipeline graph, but when someone clicks on a build, show a 404? That seems inconsistent.

    I can see the value in seeing the pipeline graph, but then I have to question why we're blocking the build detail page, and if it's just because the build logs may disclose sensitive information, then perhaps we should just hide that information, but still show meta information about the build. At least that wouldn't be consistent, but that also feels like a bigger change.

    So, going the other way, unless we want to introdue finer permissoins, it makes sense that if you've disabled public builds, that you're disabling public view of any portion of pipelines.

  • @zj Can you clarify what this MR actually does in the description?

  • Zeger-Jan van de Weg Milestone changed to %8.15

    Milestone changed to %8.15

  • Zeger-Jan van de Weg Added 3053 commits:

    Added 3053 commits:

    Compare with previous version

  • @brodock So this was expected behaviour. And on second thought rightfully so. Could you elaborate on you comment on the tests? Than I can move this forward and get it in 8.15 😄

  • Reassigned to @brodock

  • Added 83 commits:

    Compare with previous version

  • Gabriel Mazetto
  • Reassigned to @zj

  • @zj just one thing more to fix, and you can send to the endboss. Good job :)

  • Added 1 commit:

    Compare with previous version

  • Zeger-Jan van de Weg Resolved all discussions

    Resolved all discussions

  • Reassigned to @brodock

  • Added 1 commit:

    Compare with previous version

  • @zj changes looks good 👍🏻, please send to the endboss.

  • Reassigned to @zj

  • @zj I just have a nitpick in the spec, otherwise this looks good!

  • Reassigned to @zj

  • Zeger-Jan van de Weg Resolved all discussions

    Resolved all discussions

  • Fixed and ammended.

  • Added 1 commit:

    Compare with previous version

  • Sean McGivern
  • Sean McGivern enabled an automatic merge when the build for 8f174170 succeeds

    enabled an automatic merge when the build for 8f174170 succeeds

  • Zeger-Jan van de Weg canceled the automatic merge

    canceled the automatic merge

  • added 271 commits

    Compare with previous version

  • Zeger-Jan van de Weg resolved all discussions

    resolved all discussions

  • added 1 commit

    Compare with previous version

  • @smcgivern Could you take a look today? This should be ready.

    Last time it failed as the merge base had a failing test.

  • merged

  • Sean McGivern mentioned in commit 0ff8f002

    mentioned in commit 0ff8f002

  • @zj thanks, merged! 💯

    Edited by Sean McGivern
  • Grzegorz Bizon mentioned in merge request !8711 (merged)

    mentioned in merge request !8711 (merged)

  • mentioned in issue #34708 (closed)

  • Please register or sign in to reply
    Loading