Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !6802

Merged
Created Oct 11, 2016 by Yorick Peterse@yorickpeterseMaintainer7 of 7 tasks completed7/7 tasks

Processing Commits Using Sidekiq

  • Overview 64
  • Commits 6
  • Pipelines 11
  • Changes 19

What does this MR do?

This moves the code of GitPushService#process_commit_messages into a separate Sidekiq worker. This allows processing of commits to happen in parallel, speeding up the process. See the individual commit (messages) for more information.

Are there points in the code the reviewer needs to double check?

As far as I could tell/test the behaviour is the same as before (logic wise), but an extra pair of eyes on this would be appreciated.

Why was this MR needed?

Processing commits in sequence is hella slow, especially when commits mention a lot of issues.

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/15463

Assignee
Assign to
Reviewer
Request review from
8.14
Milestone
8.14 (Past due)
Assign milestone
Time tracking
Source branch: process-commits-using-sidekiq