Skip to content

Resolve "Build/Pipeline/Environment List Inconsistency Row Height"

Annabel Dunstone Gray requested to merge 23167-min-row-height into master

What does this MR do?

  • Changes generic table class from builds to ci-table. It was getting confusing using builds for builds, pipelines, environments
  • Sets height on builds rows for continuity

Are there points in the code the reviewer needs to double check?

Apparently you can't set min-height on any table elements but you can set height. For some reason, even if the content within happens to start wrapping, the row height will grow instead of letting the content overlap. Which is a good thing. Just kind of weird.

Why was this MR needed?

Different row heights on builds depending on content

Screenshots (if relevant)

Before:
Screen_Shot_2016-10-10_at_4.49.58_PM After:
Screen_Shot_2016-10-10_at_4.32.03_PM Before:
Screen_Shot_2016-10-10_at_4.44.23_PM After:
Screen_Shot_2016-10-10_at_4.42.56_PM

What are the relevant issue numbers?

Closes #23167 (closed)

Merge request reports