Skip to content

Remove spinach retry.

Connor Shea requested to merge cs-really-fix-spinach into master

What does this MR do?

This makes Spinach tests actually run rather than passing no matter what. It does, however, disable retry of Spinach tests. For now I think this is a fair trade as the longer this issue is allowed to continue, the more tests will be failing on master by the time we get it properly fixed.

Are there points in the code the reviewer needs to double check?

This MR may fail some tests, but this should be merged regardless. The Spinach test suite needs to be run to prevent further failures from popping up. Someone else (e.g. not me since I'm just a core team member 😛) should fix any failing Spinach tests after this gets merged.

Why was this MR needed?

Spinach builds would always succeed even though the test suite was never even run.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#22546 (closed)

cc: @ayufan @stanhu

Merge request reports