Skip to content

Only hide deploy status external link on x-small screens.

Bryce Johnson requested to merge deploy-widget into master

What does this MR do?

Fixes a regression where the deploy status widget hides only the text within the widget, and only for screens within bootstrap's 'small' range (≥544px - <768px).

Are there points in the code the reviewer needs to double check?

I changed the viewport width range to hide the widget from sm to xs because when the external link is removed, it seems to fit comfortably even on xs viewports.

Given that we were already hiding the external link (along with all of the deploy text) on sm viewports, I assume it's okay to hide the external link still, instead of wrapping it to a new line.

We could remove the conditional hiding altogether though, and allow the external link to wrap. Definitely doesn't look as nice, but if it's important to show the external link along with the deploy status, we could make it look better when it wraps.

Why was this MR needed?

Looked buggy, and prevented context being given for build passed icon on smaller screens.

Screenshots (if relevant)

Before:

57efae92cd57c192075546

After:

57efaeb41b211194979047

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/22778

cc: @jschatz1

Merge request reports