Improve ldap:check errors
What does this MR do?
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21621.
Introduce better credential and error checking for the rake gitlab:ldap:check task.
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
It was previously possible for invalid credential errors to go unnoticed in this task. Users would believe everything was configured correctly and then sign in would fail with 'Invalid credentials'. This adds a specific bind check, plus catches errors connecting to the server.
Screenshots (if relevant)
Success
Failed
Anonymous
Cannot connect
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if you do - rebase it please) -
Squashed related commits together