Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !6492

Fix Cycle Analytics landing widget state and improve state management in Vue.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fatih Acet requested to merge cycle-analytics-js-improvements into master Sep 23, 2016
  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 2

What does this MR do?

  • Fixes Cycle Analytics help widget show/hide issue
  • Addresses initial MR feedback with improving Vue state management logic
  • Fixes cookie path of the help widget so when you close a help widget in a repo it won't be visible for other repos.

Are there points in the code the reviewer needs to double check?

  • Should we move gl.cycleAnalyticsModel to a new file.

Why was this MR needed?

  • Addresses feedbacks of initial MR and fixes #22483 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Fixes #22483 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cycle-analytics-js-improvements