Refactor boards_spec.rb to avoid code duplication

Originally created to address #21197 (closed), but !6224 (merged) solved the intermittent spec failures.

Milestone changed to %8.11

Added ~149423 label

Reassigned to @dbalexandre

/cc: @iamphill, @rdavila

Reassigned to @axil

Reassigned to @stanhu

It looks like there are a few more test cases that need this additional check.

Closing in favor of !6198 (merged).

Status changed to closed

mentioned in merge request !6198 (merged)

I got another boards_spec.rb failiure with !6198 (merged), so I'm reopening this.

Status changed to reopened

Added 1 commit:

• 8ea13597 - Add more specs to test all boards to prevent intermittent failures

Added 1 commit:

• 20ccb1b0 - Fix rubocop error with boards_spec

Added 1 commit:

• ebe6d190 - Call wait_for_ajax to ensure requests are complete

Added 1 commit:

• 2083f70a - Call wait_for_ajax after every drag_to

Added 1 commit:

• 03a39ab8 - Wait for Ajax requests to complete

@stanhu thanks for refactoring it! We probably want to mention it somewhere in best practices that when write feature test - make sure you wait for ajax call result before ending test case

Added 1 commit:

• 9bfc1d40 - Add specs to confirm card movement

Added 1 commit:

• 332d517c - Clean up backlog spec

@stanhu Nice work here! Thanks

thanks for handling this issue @stanhu!

Still seeing periodic failures even with these changes. It looks like dragging from one board to another updates optimistically and does not require the backend API endpoints to update the frontend. This makes it harder to wait for the backend to finish. :)

@iamphill Can you clarify how Vue.activeResources is being updated? This looks to me that every HTTP request gets cleared from the queue every 500 ms instead of waiting for them to actually finishing: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/boards/vue_resource_interceptor.js.es6#L5-7

Added 1 commit:

• fe8c60d5 - Fix VueJS interceptor to subtract number of activeResources as responses arrive

Added 1 commit:

• a9474789 - Fix indentation of VueJS interceptor

@stanhu It was waiting for the next tick & then waiting a little longer to make sure it was complete before decreasing it. But looking at your way - it might work better!

I think the VueJS changes extracted in !6224 (merged) actually addresses the root cause of these failures. I think the spec refactorings are still helpful, so I'll continue this after !6224 (merged) is merged.

Also note it takes 7 minutes to run boards_spec.rb. I'm not sure why it takes that long, but that seems too long.

Removed ~149423 label

Milestone changed to %8.12

@stanhu Ping!

Added ~506179 label

Changed title: Fix intermittent spec failures in boards_spec.rb → Refactor boards_spec.rb to avoid code duplication

Reassigned to @rymai

Added 579 commits:

• a9474789...d38499b3 - 578 commits from branch master
• c0a7eb38 - Refactor boards_spec.rb to avoid code duplication

Thanks @stanhu!

Status changed to merged

Mentioned in commit 62516461

Added ~149423 label

it was shipped with RC5

Removed ~149423 label

Mentioned in issue #23034 (closed)

mentioned in issue #24899 (closed)