Skip to content
Snippets Groups Projects

Deleting source project with existing fork link should close all related merge requests

All threads resolved!

What does this MR do?

Deleting source project with existing fork link should close all related merge requests and shouldn't render invalid template for merge requests with deleted source project. The merge request without source project can be edited but can't be reopened.

Screenshots

Before was rendered invalid template: Zrzut_ekranu_2016-09-13_o_12.18.08

After is rendered show with message about missing source project: Zrzut_ekranu_2016-09-13_o_12.14.14

Does this MR meet the acceptance criteria?

  • [CHANGELOG]
  • Tests
    • Added for this feature/bug
    • All builds are passing

What are the relevant issue numbers?

Closes #21636 (closed)

cc @ubudzisz @yorickpeterse @grzesiek @tmaczukin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yorick Peterse Milestone changed to %8.12

    Milestone changed to %8.12

  • Yorick Peterse Added ~164274 label

    Added ~164274 label

  • Yorick Peterse
  • Reassigned to @kradydal

  • Katarzyna Kobierska Added 176 commits:

    Added 176 commits:

    • 0fb823d9...43d6328f - 170 commits from branch gitlab-org:master
    • 63f21512 - Before deleting project if forked unlink fork
    • 4dfe04e6 - Checks if deleting forked project closed all open merge requests
    • 4c9a57b2 - Add #closed_without_source_project?
    • cae6b255 - Add test checking method closed_without_source_project
    • e8ba93e7 - Add method
    • bf38978f - Add #can_reopen? and tests
  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • @yorickpeterse could you take a look? I added method can_reopen?and unit tests.

  • Added 2 commits:

  • Katarzyna Kobierska Marked the task Added for this feature/bug as completed

    Marked the task Added for this feature/bug as completed

  • Katarzyna Kobierska Added 128 commits:

    Added 128 commits:

    • 53ca6d3b...796bdf1d - 120 commits from branch gitlab-org:master
    • 9321dc3a - Before deleting project if forked unlink fork
    • 75fbb927 - Checks if deleting forked project closed all open merge requests
    • c023c85a - Add #closed_without_source_project?
    • 074172e4 - Add test checking method closed_without_source_project
    • 64a2e98c - Add method
    • f26c2653 - Add #can_reopen? and tests
    • ea7b1d2e - Improve grammar
    • 09a5c1b1 - Add CHANGELOG
  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • Katarzyna Kobierska Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Katarzyna Kobierska Marked the task All builds are passing as completed

    Marked the task All builds are passing as completed

  • @yorickpeterse could you take a look in your spare time? What do you think? :slight_smile:

  • Katarzyna Kobierska Added 54 commits:

    Added 54 commits:

    • 09a5c1b1...6c8516db - 46 commits from branch gitlab-org:master
    • 83afb454 - Before deleting project if forked unlink fork
    • dd3d06e3 - Checks if deleting forked project closed all open merge requests
    • 86dfeb51 - Add #closed_without_source_project?
    • 959d1655 - Add test checking method closed_without_source_project
    • 1698fad3 - Add method
    • 2ce3031a - Add #can_reopen? and tests
    • 6a445a02 - Improve grammar
    • c70295f6 - Add CHANGELOG
  • Katarzyna Kobierska Added 12 commits:

    Added 12 commits:

  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • Katarzyna Kobierska Added 30 commits:

    Added 30 commits:

    • 8ce2f355...6b88cc64 - 21 commits from branch gitlab-org:master
    • 736d9830 - Before deleting project if forked unlink fork
    • 0d500b45 - Checks if deleting forked project closed all open merge requests
    • 48c6dd2a - Add #closed_without_source_project?
    • 37b7223d - Add test checking method closed_without_source_project
    • 93ccfeaf - Add method
    • 9705c655 - Add #can_reopen? and tests
    • d8969416 - Improve grammar
    • 568b8443 - Add CHANGELOG
    • 6696285f - Fix not working test with execute
  • Katarzyna Kobierska Changed title: Resolve "Deleting source project with existing fork link should close all related merge requests"Deleting source project with existing fork link should close all related merge requests

    Changed title: Resolve "Deleting source project with existing fork link should close all related merge requests"Deleting source project with existing fork link should close all related merge requests

  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • Reassigned to @rymai

  • @kradydal Nice work, could you add screenshots of the change (if applicable)? Thanks!

  • Katarzyna Kobierska Added 31 commits:

    Added 31 commits:

  • @rymai Screenshots added, and small grammar mistake fixed :smiley:

  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • @kradydal Thanks, I had a few more remarks, great work!

  • Katarzyna Kobierska Added 20 commits:

    Added 20 commits:

    • 984bd2b1...a0c46221 - 9 commits from branch gitlab-org:master
    • 8c77a1fb - Before deleting project if forked unlink fork
    • 09cded29 - Checks if deleting forked project closed all open merge requests
    • 31c37c6c - Add #closed_without_source_project?
    • 81da7f13 - Add test checking method closed_without_source_project
    • 554baec9 - Add method
    • 34c146a1 - Add #can_reopen? and tests
    • d88f708b - Improve grammar
    • 0437842d - Add CHANGELOG
    • bef1292c - Fix not working test with execute
    • 34586c18 - Improve grammar
    • 66e92895 - Change method name to #reopenable?
  • Katarzyna Kobierska Resolved all discussions

    Resolved all discussions

  • @rymai I've made changes as you suggested.

  • Rémy Coutable Status changed to merged

    Status changed to merged

  • Rémy Coutable mentioned in commit 404f438f

    mentioned in commit 404f438f

  • Bot Mentioned in issue #22248 (closed)

    Mentioned in issue #22248 (closed)

  • Katarzyna Kobierska Mentioned in merge request !6383 (merged)

    Mentioned in merge request !6383 (merged)

  • Bot Mentioned in issue #22255 (closed)

    Mentioned in issue #22255 (closed)

  • Mentioned in issue #21636 (closed)

  • Rémy Coutable Mentioned in commit 1e7ea64e

    Mentioned in commit 1e7ea64e

  • Rémy Coutable Mentioned in commit 404f438f

    Mentioned in commit 404f438f

  • Mentioned in issue #22296 (closed)

  • Please register or sign in to reply
    Loading