Deleting source project with existing fork link should close all related merge requests
What does this MR do?
Deleting source project with existing fork link should close all related merge requests and shouldn't render invalid
template for merge requests with deleted source project. The merge request without source project can be edited but can't be reopened.
Screenshots
Before was rendered invalid template
:
After is rendered show
with message about missing source project
:
Does this MR meet the acceptance criteria?
-
[CHANGELOG] - Tests
-
Added for this feature/bug -
All builds are passing
-
What are the relevant issue numbers?
Closes #21636 (closed)
Merge request reports
Activity
Added 1 commit:
- 37724423 - Add #closed_without_source_project?
Added 70 commits:
-
37724423...ae1da08f - 66 commits from branch
gitlab-org:master
- 5d49c750 - Before deleting project if forked unlink fork
- ce7f909b - Checks if deleting forked project closed all open merge requests
- aa553e6d - Add #closed_without_source_project?
- 0fb823d9 - Add test checking method closed_without_source_project
Toggle commit list-
37724423...ae1da08f - 66 commits from branch
- Resolved by Yorick Peterse
Milestone changed to %8.12
- Resolved by Katarzyna Kobierska
- Resolved by Katarzyna Kobierska
- Resolved by Katarzyna Kobierska
Reassigned to @kradydal
Added 176 commits:
-
0fb823d9...43d6328f - 170 commits from branch
gitlab-org:master
- 63f21512 - Before deleting project if forked unlink fork
- 4dfe04e6 - Checks if deleting forked project closed all open merge requests
- 4c9a57b2 - Add #closed_without_source_project?
- cae6b255 - Add test checking method closed_without_source_project
- e8ba93e7 - Add method
- bf38978f - Add #can_reopen? and tests
Toggle commit list-
0fb823d9...43d6328f - 170 commits from branch
@yorickpeterse could you take a look? I added method
can_reopen?
and unit tests.- Resolved by Katarzyna Kobierska
- Resolved by Katarzyna Kobierska
Added 128 commits:
-
53ca6d3b...796bdf1d - 120 commits from branch
gitlab-org:master
- 9321dc3a - Before deleting project if forked unlink fork
- 75fbb927 - Checks if deleting forked project closed all open merge requests
- c023c85a - Add #closed_without_source_project?
- 074172e4 - Add test checking method closed_without_source_project
- 64a2e98c - Add method
- f26c2653 - Add #can_reopen? and tests
- ea7b1d2e - Improve grammar
- 09a5c1b1 - Add CHANGELOG
Toggle commit list-
53ca6d3b...796bdf1d - 120 commits from branch
@yorickpeterse could you take a look in your spare time? What do you think?
Added 54 commits:
-
09a5c1b1...6c8516db - 46 commits from branch
gitlab-org:master
- 83afb454 - Before deleting project if forked unlink fork
- dd3d06e3 - Checks if deleting forked project closed all open merge requests
- 86dfeb51 - Add #closed_without_source_project?
- 959d1655 - Add test checking method closed_without_source_project
- 1698fad3 - Add method
- 2ce3031a - Add #can_reopen? and tests
- 6a445a02 - Improve grammar
- c70295f6 - Add CHANGELOG
Toggle commit list-
09a5c1b1...6c8516db - 46 commits from branch
- Resolved by Katarzyna Kobierska
Added 12 commits:
-
c70295f6...45afdbef - 3 commits from branch
gitlab-org:master
- 03d9ee73 - Before deleting project if forked unlink fork
- 7573e6ca - Checks if deleting forked project closed all open merge requests
- d9c365a6 - Add #closed_without_source_project?
- e223b2c7 - Add test checking method closed_without_source_project
- 735cacbb - Add method
- f9f0a0ee - Add #can_reopen? and tests
- 082f2f4d - Improve grammar
- 8ce2f355 - Add CHANGELOG
- 350ea8b1 - Fix test
Toggle commit list-
c70295f6...45afdbef - 3 commits from branch
Added 30 commits:
-
8ce2f355...6b88cc64 - 21 commits from branch
gitlab-org:master
- 736d9830 - Before deleting project if forked unlink fork
- 0d500b45 - Checks if deleting forked project closed all open merge requests
- 48c6dd2a - Add #closed_without_source_project?
- 37b7223d - Add test checking method closed_without_source_project
- 93ccfeaf - Add method
- 9705c655 - Add #can_reopen? and tests
- d8969416 - Improve grammar
- 568b8443 - Add CHANGELOG
- 6696285f - Fix not working test with execute
Toggle commit list-
8ce2f355...6b88cc64 - 21 commits from branch
Reassigned to @rymai
- Resolved by Katarzyna Kobierska
@kradydal Nice work, could you add screenshots of the change (if applicable)? Thanks!
Added 31 commits:
-
6696285f...f7be904a - 21 commits from branch
gitlab-org:master
- 890445d0 - Before deleting project if forked unlink fork
- 34a56c1b - Checks if deleting forked project closed all open merge requests
- 83cc67f1 - Add #closed_without_source_project?
- acebc800 - Add test checking method closed_without_source_project
- d1f5b125 - Add method
- 9782f8ac - Add #can_reopen? and tests
- 48a560a4 - Improve grammar
- 8a460d13 - Add CHANGELOG
- 96f63e49 - Fix not working test with execute
- 984bd2b1 - Improve grammar
Toggle commit list-
6696285f...f7be904a - 21 commits from branch
@rymai Screenshots added, and small grammar mistake fixed
- Resolved by Katarzyna Kobierska
- Resolved by Katarzyna Kobierska
- Resolved by Katarzyna Kobierska
@kradydal Thanks, I had a few more remarks, great work!
Added 20 commits:
-
984bd2b1...a0c46221 - 9 commits from branch
gitlab-org:master
- 8c77a1fb - Before deleting project if forked unlink fork
- 09cded29 - Checks if deleting forked project closed all open merge requests
- 31c37c6c - Add #closed_without_source_project?
- 81da7f13 - Add test checking method closed_without_source_project
- 554baec9 - Add method
- 34c146a1 - Add #can_reopen? and tests
- d88f708b - Improve grammar
- 0437842d - Add CHANGELOG
- bef1292c - Fix not working test with execute
- 34586c18 - Improve grammar
- 66e92895 - Change method name to #reopenable?
Toggle commit list-
984bd2b1...a0c46221 - 9 commits from branch
@rymai I've made changes as you suggested.
mentioned in commit 404f438f
Mentioned in issue #22248 (closed)
Mentioned in merge request !6383 (merged)
Mentioned in issue #22255 (closed)
Mentioned in issue #21636 (closed)
Mentioned in commit 1e7ea64e
Mentioned in commit 404f438f
Mentioned in issue #22296 (closed)