Skip to content

WIP: UI: Allow for project variable to be set empty

Lukáš Nový requested to merge lnovy/gitlab-ce:patch-5 into master

What does this MR do?

This changes project variables UI form to allow variable's value to be set empty.

Are there points in the code the reviewer needs to double check?

I've also robustified some other scenarios in the test spec besides adding a new one which tests the empty value.

Why was this MR needed?

Empty valued environment variables are perfectly valid and useful. Setting the value empty can also server as a poor-man's way to "unset" the variable if it was defined somewhere lower in the order of precedence as documented at [http://docs.gitlab.com/ce/ci/variables/README.html]

What are the relevant issue numbers?

Nope.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

Merge request reports