Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !6029

Fix diff comments on legacy MRs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sean McGivern requested to merge 21211-comment-on-diff-partially-broken-after-updating-to-8-11 into master Aug 25, 2016
  • Overview 5
  • Commits 2
  • Pipelines 1
  • Changes 4

What does this MR do?

Allow diff commenting on MRs without complete diff refs. (Commenting would work before, but the JSON response would fail, so you'd only see your comment after a refresh.)

Are there points in the code the reviewer needs to double check?

Is this really all I needed to do? I feel like there must be more to it 😊

Why was this MR needed?

It's a regression!

What are the relevant issue numbers?

Closes #21211 (closed).

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21211-comment-on-diff-partially-broken-after-updating-to-8-11