Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !5989

Handle unavailable system info

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sean McGivern requested to merge 21378-error-500-after-8-11-update-on-system-infos-page into master Aug 24, 2016
  • Overview 11
  • Commits 3
  • Pipelines 1
  • Changes 6

What does this MR do?

Handle the case where we can't get system info without blowing up. As this is the first tab in the monitoring section, it's difficult to get to the other tabs if this page throws a 500. Also be more specific about the info we want, so we don't fail on something we don't care about (like /proc/net/dev).

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

grsecurity can prevent users from reading /proc, which is what Vmstat uses to find CPU and memory info.

What are the relevant issue numbers?

Closes #21378 (closed).

Screenshots (if relevant)

image

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21378-error-500-after-8-11-update-on-system-infos-page