Change the order of the access rules to check simpler first, and add specs
What does this MR do?
Change the order of the access rules to check simpler first, and add specs
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
The specs added here cover the CE behaviour. These specs are expanded to cover EE behaviour for the changes in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/647
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together