Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !5797

Allow to sort by project size on admin projects page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alfredo Sumaran requested to merge 20317-admin-cant-order-by-size into master Aug 12, 2016
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

What does this MR do?

Restores dropdown option Largest repository on admin projects page

Are there points in the code the reviewer needs to double check?

Check if admin_projects_sort_options_hash is really needed. The option to sort by Largest repository was only present on the admin area, when this section got redesigned I wanted to re-use the shared dropdown partial but the Largest repository option was missing. Since /admin/projects have this additional sorting option I thought is convenient to have another hash options for the admin area. Another approach would have been to allow to sort by Largest repository everywhere else but that will require design work for other views.

Why was this MR needed?

Because of missing option reported by user.

What are the relevant issue numbers?

Fixes #20317 (closed)

Screenshots (if relevant)

Screen_Shot_2016-08-12_at_3.19.38_PM

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together Closes #20317 (closed)
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 20317-admin-cant-order-by-size