Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !4985

Use update_columns to by_pass all the dirty code on active_record

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Paco Guzman requested to merge 18663-avoid-extra-yaml-serializations into master Jun 29, 2016
  • Overview 16
  • Commits 1
  • Changes 2

What does this MR do?

Speed up storing current content of merge_request_diff instances, avoiding YAML deserialization and serialization

What are the relevant issue numbers?

#18663 (moved) one of the points of improvement

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • [ ] Documentation created/updated
  • [ ] API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 18663-avoid-extra-yaml-serializations