Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !4789

Handle external issues in IssueReferenceFilter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Yorick Peterse requested to merge fix-external-issue-links into master Jun 20, 2016
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 2

What does this MR do?

This MR fixes handling of external issues in IssueReferenceFilter.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Handling of external issues was broken when I refactored IssueReferenceFilter to use fewer SQL queries.

What are the relevant issue numbers?

#18827 (closed)

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added Not really needed since the changes this fixes weren't released in a previous minor release
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-external-issue-links