Make docker registry work with location redirects when external storage is used (!4677) · Merge requests · GitLab.org / GitLab FOSS · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The second breaking change window begins 2024-04-29 09:00 UTC and ends 2024-05-01 22:00 UTC.

Kamil Trzciński requested to merge docker-registry-work-with-redirect into master Jun 15, 2016

What does this MR do?

Honor Location: header when working with local registry. Location makes it possible to download manifests from external storage.

What are the relevant issue numbers?

Fixed https://gitlab.com/gitlab-org/gitlab-ce/issues/18477

Remark

Adding FollowRedirects makes that we leak Authorization: in followed requests.

That is why it is implemented manually and we are explicitly removing Authorization header.

cc @marin @twk3