Skip to content

Report 404 if user attempts to create a note on an issue in a different project via API

Stan Hu requested to merge stanhu/gitlab-ce:fix-error-500-notes-api-creation into master

Previously this would return a 500 Error:

NoMethodError (undefined method `valid?' for nil:NilClass):
/opt/gitlab/embedded/service/gitlab-rails/lib/api/notes.rb:83:in `block (3 levels) in <class:Notes>'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:51:in `call'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:51:in `block (2 levels) in generate_api_method'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.2.6/lib/active_support/notifications.rb:166:in `instrument'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:50:in `block in generate_api_method'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:254:in `call'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:254:in `block in run'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/activesupport-4.2.6/lib/active_support/notifications.rb:166:in `instrument'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:219:in `run'
/opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/grape-0.13.0/lib/grape/endpoint.rb:201:in `block in call!'

Closes #17260 (closed)

Merge request reports