Skip to content
GitLab Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !3363

Implement #3243 New Issue by email

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lin Jen-Shin requested to merge godfat/gitlab-ce:new-issue-by-email into master Mar 23, 2016
  • Overview 197
  • Commits 65
  • Pipelines 1
  • Changes 25

So we extend Gitlab::Email::Receiver for this new behaviour, however we might want to split it into another class for better testing it.

Another issue is that, currently it's using this to parse project identifier:

Gitlab::IncomingEmail.key_from_address

Which is using:

Gitlab.config.incoming_email.address

for the receiver name. This is probably reply because it's used for replying to a specific issue. We might want to introduce another config for this, or just use reply instead of incoming.

I'll prefer to introduce a new config for this, or just change reply to incoming because it would make sense for replying to there, too.

The email template used in tests were copied and modified from: emails/valid_reply.eml which I hope is ok.

/cc @DouweM #3243 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: new-issue-by-email