Skip to content

Fix code docs for RuboCop's helper methods

Peter Leitzen requested to merge pl-rubocop-const-nil into master

What does this MR do?

(const nil :Foo) does not match a constant Foo. It's (const nil? :Foo).

This came up during discussing https://gitlab.com/gitlab-org/gitlab-ce/commit/befdd4f392d1a692ca00779e9e3a58084e7094cd#note_215926384

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports