Ss/collapsed issue boards per user ce
What does this MR do?
Fixes frontend req for: https://gitlab.com/gitlab-org/gitlab-ce/issues/52758
We needed to make a request including the collapsed state if the user was logged in, if theyre not logged in we default to localStorage.
Testing thoughts as I am going through this MR:
- In board_spec.js we should make a issue to move the list specific tests in this file into the list_spec file.
- We should make an issue to move the board_spec test file to jest (i dont mind taking this on).
- I apologize for all of the changes in board_spec, we needed to reformat the test file for simplicity when porting over to jest, separating concerns, and isolating when we mount the whole vue component or not.
Implementation thoughts:
- we are maintaining list state in models/list.js, but when making http requests were accessing the lists state on the instance, not by passing the values we expect to the updated ex) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32909/diffs#c199244ae776847cbe6c9c53f65dd402a2ae01c3_117_117. Personally, this seems like a bit of a code smell and might involve a larger discussion but wanted to start the conversation here.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖