Skip to content

Add rake task `db:obsolete_ignored_columns`

Peter Leitzen requested to merge pl-remove-ignored-columns-task into master

What does this MR do?

Show a list of obsolete ignored_columns.

Follow-up to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14764.

Screenshots

rake -T

rake db:obsolete_ignored_columns  # Show a list of obsolete `ignored_columns`

With content

$ bundle exec rake db:obsolete_ignored_columns
The following `ignored_columns` are obsolete and can be removed:
- ApplicationSetting: clientside_sentry_dsn, clientside_sentry_enabled, koding_enabled, koding_url, sentry_dsn, sentry_enabled
- DiffNote: original_discussion_id
- DiscussionNote: original_discussion_id
- LegacyDiffNote: original_discussion_id
- Note: original_discussion_id
- NotificationSetting: events
- User: authentication_token, email_provider, external_email

All clear

$ bundle exec rake db:obsolete_ignored_columns
No obsolete `ignored_columns` found.'

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports