WIP: pages: domain: fix DNS records, must end with a '.'
What does this MR do?
This is a minor UI tweak to help make correct DNS records for custom pages domains. In case the domain is a root domain (example.com) a type record CNAME must not be used! I tried to clarify that. Further a DNS record must end with . after the domain otherwise the domain would be appended mypages.example.com CNAME ...
would result in mypages.example.com.example.com. CNAME ...
. I know a few DNS providers don't allow to use the dot .
after the domain depending on the interface and validation they use, however, in this case a proper error is shown, while in the case of a missing dot the record will be created in a unexpected way.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team