Break up Danger rules into local or CI only

What does this MR do?

ℹ️ This is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32196 re-attempted 🙏

This MR is part of allowing Danger to run locally by:

• Breaking up the Danger rules into an Array for local and CI only rules
• Updating some existing Danger rules to support running locally

Supported local Danger rules (right now)

• changes_size
• gemfile
• documentation
• frozen_string
• duplicate_yarn_dependencies
• prettier
• eslint
• database

Example executions:

No violations

$ bundle exec rake danger_local ; echo $?
==> Only the following Danger rules can be run locally: changes_size, gemfile, documentation, frozen_string, duplicate_yarn_dependencies, prettier, eslint, database
==> No Danger rule violations!
0

Violations

$ bundle exec rake danger_local ; echo $?
==> Only the following Danger rules can be run locally: changes_size, gemfile, documentation, frozen_string, duplicate_yarn_dependencies, prettier, eslint, database
Results:

Warnings:
- [ ] Gemfile was updated but Gemfile.lock wasn't updated.
- [ ] New migrations added but db/schema.rb wasn't updated.
- [ ] New Geo migrations added but ee/db/geo/schema.rb wasn't updated.
1

⚠ The number on the final line can be ignored as it's produced by echo $? to show the exit code that is returned and does not appear normally.

• Related - https://gitlab.com/gitlab-org/gitlab-ce/issues/66596
• EE port - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16223

Does this MR meet the acceptance criteria?

Conformity

• [ ] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• [ ] Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [ ] Database guides
• [ ] Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team