Skip to content

Do not strip HTML from / doubly escape sanitized pre-receive hook error (#42797)

Bob Weinand requested to merge (removed):42797-pre-receive-hook-display into master

Multi-line output of merge failures (custom hooks) contains <br>.

This is similar to #42797 (moved), but even worse and in particular displayed in the always present output. Especially with a longer output this is absolutely unreadable...

This MR removes this double escaping at all places reading the merge error message. This is safe as merge errors are already sanitized on the backend side.

Previous output

image

New output

image

Closes #42797 (moved)

Merge request reports