Add support for custom domains to the Pages internal API

What does this MR do?

This is another extraction from https://gitlab.com/gitlab-org/gitlab-ce/issues/61927 in order break the later in smaller chunks.

This MR add support for custom pages domains to the endpoint introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32732. Namespaces domains are intentionally left out cause this is where the data migration and tricky queries will happen, this way we can introduce most of the code we'll eventually need before we add the last piece.

Keep in mind this branch is based on https://gitlab.com/gitlab-org/gitlab-ce/tree/61927-skeleton-pages-internal-api and can be merged only once https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32732 is merged.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related #61927 (moved)

changed milestone to %12.3

added Category:Pages Deliverable devopsrelease [DEPRECATED] workflowin review + 1 deleted label

removed workflowin review label

	2 Warnings
	5374f423: This commit’s subject line is acceptable, but please try to reduce it to 50 characters.
	676675dc: This commit’s subject line is acceptable, but please try to reduce it to 50 characters.

	1 Message
	CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with: bin/changelog -m 32735 "Add support for custom domains to the Pages internal API" Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Brett Walker (@digitalmoksha)	Thong Kuah (@tkuah)

Generated by Danger

@vshushlin This is another piece extracted from https://gitlab.com/gitlab-org/gitlab-ce/issues/61927. Can you please take a look?

This is currently targeting https://gitlab.com/gitlab-org/gitlab-ce/tree/61927-skeleton-pages-internal-api, I'll wait for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32732 to be merged and update the target branch before passing it to maintainer.

assigned to @vshushlin

added typefeature label

unassigned @vshushlin

added 1 commit

• 0d0c8168 - Fix

Compare with previous version

added 1 commit

• f7c4e615 - Add support for custom domains to the Pages internal API

Compare with previous version

added 204 commits

• f7c4e615...435d06d6 - 204 commits from branch 61927-skeleton-pages-internal-api

Compare with previous version

changed the description

changed target branch from 61927-skeleton-pages-internal-api to master

added 1 commit

• 676675dc - Add support for custom domains to the internal Pages API

Compare with previous version

resolved all threads

@ayufan Another piece extracted from https://gitlab.com/gitlab-org/gitlab-ce/issues/61927. There should be just one more with all the tricky stuff.

assigned to @ayufan

unassigned @ayufan

added 3 commits

• 268c698f - Add tests for Pages::VirtualDomain
• 5809400d - Add tests for PagesDomain#pages_virtual_domain
• 91af0cf4 - Add tests for Project#pages_lookup_path

Compare with previous version

added 1 commit

• 5374f423 - Add tests for ProjectFeature's #public_pages? and #private_pages?

Compare with previous version

assigned to @ayufan

approved this merge request

resolved all threads

@krasio lets keep this going :)

marked the checklist item Code review guidelines as completed

marked the checklist item Merge request performance guidelines as completed

marked the checklist item Style guides as completed

marked the checklist item Separation of EE specific content as completed

merged

mentioned in commit 68e8bbdb

mentioned in merge request !32945 (closed)

mentioned in issue gitlab#28781 (closed)