Skip to content

Flesh out more specifics around code review

What does this MR do?

This MR performs the following actions to the Code Review document:

  • Adds more items to Reviewing Code section
  • Adds 'The responsibility of the reviewer' section
  • Fleshes out responsibility of the MR author section

'Moved' over to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16597

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ash McKenzie

Merge request reports