Skip to content

Optimize queries for snippet listings

Markus Koller requested to merge 65988-optimize-snippet-listings into master

What does this MR do?

This addresses https://gitlab.com/gitlab-org/gitlab-ce/issues/65988 (moved to gitlab#30877 (closed)) to improve the performance of snippet listings:

  • Avoid N+1 queries for authors and comment counts
  • Avoid an additional snippet existence query (down from 3 to 2)

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports