Skip to content

Show cluster link on job page

Dylan Griffith requested to merge 55095-show-cluster-on-job into master

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16361

What does this MR do?

Show the cluster used for a deployment on the job page. Make the cluster name a link to the cluster page if the user has permission to view the cluster page.

Screenshots

I didn't add seperate screenshots for group clusters but I did test this for both users that should have access to the group cluster and not and everything behaved as expected and the links went to the correct place.

Deployment with cluster

User During After Out of date
Maintainer Screen_Shot_2019-09-02_at_1.12.11_pm Screen_Shot_2019-09-02_at_12.59.27_pm Screen_Shot_2019-09-02_at_1.00.49_pm
Developer Screen_Shot_2019-09-02_at_4.37.53_pm Screen_Shot_2019-09-02_at_4.36.56_pm Screen_Shot_2019-09-02_at_4.37.17_pm

Deployment with no cluster

During After
Screen_Shot_2019-09-02_at_12.56.07_pm Screen_Shot_2019-09-02_at_12.56.44_pm

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#55095 (moved)

Edited by 🤖 GitLab Bot 🤖

Merge request reports