Approval rules based on labels for Product Designers (UX)
What does this MR do?
Tentativelly adds UX reviewer role to danger bot, based on approval labels. See https://gitlab.com/gitlab-org/gitlab-ee/issues/13674
In the example above, it would be more accurate to determine the approvers based on labels. A merge request with the UX label should include a UX approver.
I'm not totally familiar with Ruby, so this MR is a shot in the dark. Feedback is welcome and appreciated!
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team