Skip to content

Show performance bar warnings

Sean McGivern requested to merge show-performance-bar-warnings into master

What does this MR do?

Following on from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31054, this presents the warnings from the backend to the user.

Right now, the performance bar is unopinionated: it will tell you how many SQL queries a page ran, but not if that's good or bad. It also hides away AJAX requests behind a dropdown, which means people are less likely to see those requests.

This adds a way of highlighting warnings generated by the backend in both places. In a request itself, a metric will have a warning item if the backend thinks it's too slow. And in the request selector, we highlight requests that have warnings associated.

Screenshots

This shows a request that has no warnings, but there are other requests that do have warnings:

image

When I open the request selector, I see the request with warnings:

image

When I pick that request, I see Gitaly warnings:

image

And hovering over those tells me why:

image

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/64179.

Edited by Sean McGivern

Merge request reports