WIP: Unleash PoC
What does this MR do?
PoC for Unleash on gitlab.com.
Relevant Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/57943
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.3
added backend devopsrelease [DEPRECATED] typefeature + 1 deleted label
1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.1 Message CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with:
bin/changelog -m 32301 "Unleash PoC"
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Adriel Santiago ( @adrielsantiago
)Kushal Pandya ( @kushalpandya
)backend Alex Kalderimis ( @alexkalderimis
)Nick Thomas ( @nick.thomas
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #57943 (moved)
mentioned in merge request !32127 (closed)
added 347 commits
-
6ba255f4...663b7bb4 - 345 commits from branch
master
- a657155e - Use Unleash for a single feature
- 4dddeb25 - Delete feature flag client spec
-
6ba255f4...663b7bb4 - 345 commits from branch
- lib/feature_flag_client.rb 0 → 100644
1 # frozen_string_literal: true 2 3 class FeatureFlagClient 4 def self.enabled?(key, user: nil, thing: nil, default_enabled: false) 5 if Feature.enabled?(:gitlab_feature_flag_client) && client