Skip to content

Fix users cannot access job detail page when deployable does not exist

What does this MR do?

As some on-prem customers and sentry reports, sometimes deployment.deployable becomes nil. Because of that, JobController#show raises an exception and it disturbs user's workflow.

This MR gracefully handles the case by explicitly checking the object existence.

Close https://gitlab.com/gitlab-org/gitlab-ce/issues/65216

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports