Skip to content

WIP: Dry up project feature access logic

Michael Kozono requested to merge mk/dry-up-access-logic into master

What does this MR do?

Dries up some project access logic.

ProjectFeature.feature_available? logic is partially duplicated in ProjectPolicy (or the other way around?), I assume for performance. This makes me slightly uncomfortable. If we dry it up, then they will be perfectly consistent.

  • Maybe this is a non-starter, for performance reasons?

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports