Extract service properties into own module
What does this MR do?
This MRs extracts the properties functionality from the Service
module into an own module ServiceProperties
. It also adds some missing specs (mostly boolean_accessor
) and removes some superfluous specs from service_spec.rb
.
Reason: After extracting it's easier to add more functionality (such as "encrypted properties" soon to come) to this module.
Part of https://gitlab.com/gitlab-org/gitlab-ee/issues/13203
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen