Skip to content

Extract service properties into own module

Peter Leitzen requested to merge pl-extract-service-props into master

What does this MR do?

This MRs extracts the properties functionality from the Service module into an own module ServiceProperties. It also adds some missing specs (mostly boolean_accessor) and removes some superfluous specs from service_spec.rb.

Reason: After extracting it's easier to add more functionality (such as "encrypted properties" soon to come) to this module.

Part of https://gitlab.com/gitlab-org/gitlab-ee/issues/13203

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports