[WIP] Moves the stage and ref from the table in a ci commit build to a plain one line text

Removes redundancy from Build table and shows stage and ref on a one liner above the table instead

This is referenced to the issue #14164 (closed)

@dzaporozhets I think this is it, but I think it still needs some revamp in design though

Smart. 👍

This seems like a something that will break other views.

We should use defined(sth) to check which columns should we show.

Hm okok will change that then :)

btw @ayufan If I do the defined?(sth) won't it be true? The variable ref is actually defined in projects :/ Not sure how to do this part

@tiagonbotelho thanks. I leave this up to @ayufan to review and merge

mentioned in issue #13559 (closed)

Added 1 commit:

• 21eeaa49 - changes stage back to original position

@ayufan Fixed the status column but still need help with the ref part :) Thanks!

Reassigned to @ayufan

@ayufan anything you want me to change? :)

@tiagonbotelho First you need to rebase it on master. We did split the _commit_status into two separate views: ci/builds/_build and generic_commit_status/_generic_commit_status.

The ref column should be hidden with (in both cases):

- if defined?(ref) && ref

Then you need to change the = render to include ref: true in projects/builds/index.html, commit/_builds.html (for normal builds and also for retries).

The thing is that we need to make sure that ref doesn't get remove from this view: https://gitlab.com/gitlab-org/gitlab-ce/commit/d0898fa243a77221dd0b2a80dd919c977619ca5d/builds, because you can get a build for multiple different refs.

@ayufan I'll get onto that :)

Added 221 commits:

• 6b5a127e - add bundle clean to upgrade docs
• b5d517cc - Deprecated GitLab CI API clean up - README
• f072d05c - Update CI API docs for builds endpoint for runners
• ff310a55 - Add CI API prefix to documentation
• 5be4d41c - Update CI API documentation for runners
• 5e92469e - Remove deprecated CI API docs for commits and projects
• cc714690 - Update format of documentation for CI API
• 06dc50a3 - update slack instructions
• 59874017 - Remove duplicate 'cache_store' configuration in test environment
• 278e85bf - fix token issue - timing attack
• 87c5b12f - ensure also alternative email addresses are used when looking up user
• 4dae3eca - Security: Fix issue auto closing
• 5d866785 - Added Troubleshooting information for most used services.
• ff093ad2 - Tell clients/proxies to cache raw blob requests
• eb031ed5 - add link to web hooks
• 87742abf - Added discard button to comment form
• 8137b492 - Fixed tests for comment forms
• a2777f53 - Add fields to GET /users/* API endpoints for admins
• 82e52bed - Fixed failing comment test
• 6143e62c - Updated tests
• 38b4ff94 - Show at most 100 commits in the web UI
• 71bfd801 - Limit the number of commits shown in MRs
• f44ff78d - Put 'hidden commits' logic in CommitsHelper
• 13eb53e5 - Remove outdated comment
• 7582e59d - Add option to show archived projects on dahsboard
• 4f75a417 - Make projects sort dropdown shared so it can be reused for other pages
• c94fa4b7 - Add projects list sort dropdown to group page
• 4b0bedee - Add test for archive toggle feature
• 91745286 - Show active sorting method for projects list
• b33de3c0 - Fix test
• 61baeb42 - Align projects sort checkbox
• cf130f1a - Updated project list dropdown to use dropdown classes
• b1285fbc - Remove Snippet#expires_at
• 2ceceed7 - Finish refactor
• 3f4d24d3 - Change "some commits hidden" message
• bd1faee5 - Affix the build scroll controls
• 891b9ed6 - Revert changes in the Project model
• 55c64c53 - Refactor caching code
• db8edee6 - Add shortcut to toggle markdown preview
• cb14eda4 - make cleanup optional
• 987a9fa9 - Use Rails etag/cache_control helpers
• 9a9def0d - Fix bug where Bitbucket closed issues were imported as opened
• 126fe151 - Bump poltergeist to ~> 1.9.0
• 9c542224 - Remove redundant integration tests
• e3c4663c - Fixed headers for anchors
• 144cd580 - Document changes to the initial admin password
• 22f6363f - Support YAML alias/anchor usage in .gitlab-ci.yml
• 919d5771 - Snippet visibility badge spacing
• 80c49e38 - Updated gitlab_git to 9.0.1
• 9b20cee3 - Added basic SQL guidelines
• d114b732 - add SHA256 to secure_compare
• aff88ac7 - Remove instance variable @group multiple assignment
• 71df5b7b - Cache & flush tag/branch counts
• 440a8efe - Call the right hooks when removing branches
• c387149c - Added specs for Repository#rm_tag
• c2ddea98 - Call the right hooks in Repository#add_tag
• 464d0206 - Call after_create_branch in Repository#add_branch
• 697331f5 - Simplify the various Snippet factories
• 5be89f9f - Make better use of the visibility_level factory traits
• 22d3997d - Use a custom Devise failure app to handle unauthenticated .zip requests
• cf3a6a02 - Fix URL to upgrader guide
• b7ed4a32 - Cache only last response in markdown preview
• 37a07d76 - Prevent performance issues
• dfe09d57 - Added main_language to the schema
• 082c04b3 - Retry failed tests
• 25822dfd - Retry spinach tests
• 37ec7433 - Retry apt-get installation and bundle install
• 0491b780 - Fix script error
• 027d829e - Destroy all related todos when removing a project
• f6b513fe - Parse config/resque.yml in one place only
• d5ccdae3 - Remove invalid todos from database
• 952914b6 - Update CHANGELOG
• 3f90b11e - Always with the newlines
• f695ee2c - Fixed part of the GitPushService specs
• 3dd8776e - Handle permissions for ExternalIssue instances
• 5d7319d4 - Fix typo in shortcuts help
• b2d50c84 - Add a gemojione:sprite Rake task
• 4f2f0c82 - Avoid error 500 when todo author was removed
• b45976e2 - Acquire lock before LDAP sync
• 07f31971 - Update CHANGELOG
• 4edbe587 - Ignore .byebug_history
• 225bdab3 - Retry bundler and apt-get
• 22d7b8a9 - Set blue color for link inside .gray-content-block
• ff3625f8 - Allow filtered dashboard/explore results to be paged. Fixes #14104
• 862286a4 - Added specs for Issue#referenced_merge_requests
• 6cf824f1 - Added CSS for new dropdowns
• 18a74cf7 - Dropdown variables
• 3ea66024 - Dropdown toggle button styling
• a67ee0e5 - Rename ExpiringLock to ExclusiveLease
• 17630d83 - Explain LDAP "lock" behavior
• 99ed35e9 - Removed benchmark suite and its documentation
• 7c3ff6d5 - Decrease the font size and the padding of the .anchor icons
• 5f54c477 - Fixed quick submit on note edit
• 65a349e2 - Move method to User
• f912dd4b - Add tests for ExclusiveLease
• ab504d97 - Fixed flicker of download project button
• 5661439d - Improve test descriptions
• f9ce66ec - Improve comment
• ab35dc73 - Fixes issue with markdown snippet not being copyable
• fb59a663 - Fix projects pagination via ajax
• 684eee98 - Use modern syntax
• 03507189 - Moves build status tooltip on issues
• 7a21b070 - Move group activity feed to separate page for consistency with dashboard and project pages
• 93c24d77 - Replaced hidden div for textarea off-the screen
• f87cac12 - Fix header title
• 1978523f - GitLab dropdown JS
• 7b1581eb - Custom ID & toggle class on dropdown
• 66785cc8 - Applied new dropdowns to issue filters
• c137a871 - Fixed alignment of labels in dropdowns
• f8e2518e - Removed label colour from dropdown
• f4694bbf - Extra links in label filter dropdown fotoer
• 179a0545 - milestone dropdown
• 3e815dab - Correctly fitlers remotely
• 0434b825 - Started page two for labels dropdown to allow creating new labels
• 98a4e6ae - Can create new label from dropdown
• df513eee - Status dropdown
• 0e5daa73 - Filter alignment
• 567bedd4 - Uses a publicly facing URL so that it allows labels & milestones to be visible when not logged in
• a2f68d87 - Stops excute remote data fetcher when already recieved data
• 41e0a0cb - Fixed issue with user list not fetching current project users
• 348f95f6 - Removed fuse for fuzzaldrin
• 5e49ffe5 - Enter button trigger first row click when searching
• b42c93c9 - Correctly handles multi-selected values
• a0e1018e - Fixed ruby style errors
• 655bdb1d - Fixed failing tests
• 5f9fcd15 - Fixed failing milestone filter tests
• 163cff87 - Optimize Project#ci_service(s)
• 705003db - Removed CiBuild in favour of already available CiBuild class
• e8785432 - Remove unnecessary random key
• e9530af4 - Reduce example documentation.
• a5f60018 - rewrite logo to simplify SVG code
• ae33a71d - Changed variable names
• 28bfb06b - Add error for ajax:error when submitting comments
• 39a962b2 - Change test in an attempt to pass.
• d4b1f83b - Fixes issue with issue sidebar toggle button not working
• 44a37449 - Make comment less ambivalent
• 726cccef - Correct ruby code
• 5130e8c8 - Typo
• 3304094b - Changed named argument
• ad2e5d1b - Avoid blinking of editor area on iOS
• 9818a491 - Prevent .max-width-marker to break layout on mobile
• 19f4211d - Added redcarpet usage reference to markdown documentation
• 3a972e73 - Capitalize names of technologies
• e3de1d31 - Capitalize Rouge mentions
• 9d810dcd - Use full URL to reference issues
• 111fea9f - web hooks to webhooks
• 8b88a627 - Fix help_autocomplete alignment
• b35421d2 - Add 8.5.5 CHANGELOG items
• 1520fa29 - Upgrade omniauth-saml to 1.5.0 and document it's new capabilities.
• ae305175 - Consistently use the same hash syntax in the new documentation.
• 57a8f499 - Fix importing PR's from GitHub when the source repo was removed
• 12734527 - Filter import_url params because they may contain auth information. Fixes #14199
• e9a000f2 - Removed deprecated bootstrap classes
• 187bc123 - Fixed missing variables
• 60400835 - Updated UI of award emoji
• f5fb9151 - Updated award emoji tests
• 42b28411 - Moved SCSS values into variables
• bf7a6087 - Moved method calls to separate lines
• cefae4e8 - Renamed variables & removed some for award emoji
• 7dd82c95 - Award emoji button padding
• b726d1fa - CoffeeScript style improv.
• 3826a0ac - Fixed bug with emoji search styling
• 3574e590 - Added 'surprise' animation
• 7099b639 - Account settings
• 06cad950 - Fixed failing tests
• 4932ad5e - Updated CHANGELOG
• 502e7cf7 - Fixed heading weight issue
• 039cc237 - Fixed issue with 2fa not enabling
• 888958ce - Moved 2fa into separate view
• a6833990 - Added back 2fa configure later button
• 69e388c6 - Used standard variable colours
• 432eb572 - Correctly uses a variable with the text
• 49287dc7 - Improved search results filter dropdown
• 8ddf430f - Increased dropdown max height
• 00e577cf - Doc syntax fixes
• 1339de67 - Fix incorrect gitlab.rb variable in CI docs
• ae33cce3 - Added trigram indexes for various searched columns
• 68d2a8b2 - Use ILIKE/LIKE + UNION in Project.search
• c957321b - Use ILIKE in Project.search_by_title
• e5be8ea6 - Use ILIKE/LIKE for searching snippets
• 05c7619e - Use ILIKE/LIKE for searching notes
• b49a095d - Use ILIKE/LIKE for searching users
• 4f4101ed - Use ILIKE/LIKE for searching groups
• 0b95ce10 - Use ILIKE/LIKE for searching CI runners
• 04e477f3 - Use ILIKE/LIKE for Issuable.search and full_search
• aaf0c671 - Use ILIKE/LIKE for searching milestones
• f84f367c - Refactor Gitlab::SearchResults
• d726d994 - Refactor Gitlab::SnippetSearchResults
• a8b35a57 - Refactor Gitlab::ProjectSearchResults
• a14f2c3c - Backport Rails support for PostgreSQL opclasses
• de1788dc - Updated schema to include Pg operator classes
• 53c892a4 - Patch MySQL to ignore PostgreSQL schema options
• e479b49e - Disable Rubocop for PostgreSQL patches
• c7cac9c9 - Fixed ProjectSearchResults spec to use a Project
• 33d86b55 - Added ProjectSearchResults#project_ids_relation
• a12ccdac - Removed order from sub-query projects for search
• c1c5fa14 - Clean up ProjectsFinder for getting user projects
• 14a2124f - Fixed a few spec typos
• 0836f5ca - Removed arel_table receiver from search methods
• 0d998684 - Make Namespace.search case-insensitive
• e94f8e6a - Corrected spec title for Namespace.search
• 75dc2f79 - Added pg_trgm to the PostgreSQL requirements
• 9f4b5e49 - Added changelog entry for search performance
• 2ddbf7c4 - Use a UNION in MergeRequest.in_projects
• 51fd00df - More detailed trigram migration error message
• fd8934d8 - Fix responsive bug top navigation
• e9a5d6d1 - Disallow blank (non-null) values for a Note's line_code attribute
• 54bd2097 - Support Golang subpackage fetching
• 27169014 - Removed User#project_relations
• 451b5947 - Remove existing go_import.html.haml implementation
• 02483545 - Simplify code
• 488748de - Add spec for go-import middleware
• 2bac2691 - Ensure PATH_INFO exists for go-get
• e364ce8c - Revert "Merge branch 'support-go-subpackages' into 'master'"
• d9748aac - Remove unnecessary go-get test (superseded by middleware)
• a232e5dc - Revert "Revert "Merge branch 'support-go-subpackages' into 'master'""
• 3a979fcc - Remove duplicate entries.
• 2048c0f1 - moves the stage and ref from the table in a ci commit build to a plain one line text
• 0d0cfb05 - changes stage back to original position
• c4d18b09 - fixes defined? issue for ref and initializes it on the partials as false
• f6bcdde6 - Merge branch 'ci-commit' of gitlab.com:tiagonbotelho/gitlab-ce into ci-commit

Added 1 commit:

• 4dc07b9e - adds missing td

@ayufan Is this it?

@tiagonbotelho I got back from Holidays. I'll get it reviewed tomorrow :) Thanks!

mentioned in issue #14717 (closed)

Hahaha hope you enjoyed the holidays :) I got back from them too! Just ping here and i'll change whatever's necessary ;)

@ayufan any news? :)

@tiagonbotelho Can you verify that you rebased correctly? I'm seeing 224 commits for this MR.

@grzesiek I do not know what happened but yes I rebased the project as I usually do :/ maybe I did one step wrong :o

@tiagonbotelho It looks like something went wrong during a rebase:

$ git rev-list --count master...ci-commit
524

And most of that refs has been rewritten. Can you please correct that?

or maybe just create another branch, add changes and create another MR so it will be easy to merge

mentioned in issue #15598 (closed)

@ayufan I'm looking through the updated code and it seems this problem was already solved :) can you close the issue? Sorry it took so long to answer, been quite busy with college

Thanks for your contribution :)

Status changed to closed

mentioned in merge request gitlab-com/www-gitlab-com!2018 (merged)