WIP: Resolve "Renaming in the Web IDE causes file changes to be lost"
What does this MR do?
Ideally, this MR:
- Fixes re-naming of entries in WebIDE
- When files get both renamed & changed. we should not loose any of these operations
- Minor UX improvements to the presentation of the renamed entries
In reality, the following major issues still occur:
Re-naming entries & folders with 1-level-deep structure work, but
-
when nesting folder, the folder structure gets broken after re-naming.
| Before renaming | After renaming and clicking the subfolder |
|---|---|
 |
 |
Changes to the renamed file do get preserved, but only in case one makes changes before renaming. So the following scenarios are buggy:
-
renaming a file before making the changes. This produces only one change (re-name itself) being detected as a change without content of the file being update to the latest version 
-
when renaming a file without opening it (clicking on its name in the tree), and opening it after renaming (without comit) throws an error ion the interface and HTML page as plain text rendered instead
The MR is also missing some important tests the functionality is not yet settled. Ideally we should write a couple of integration tests in RSpec here in addition to the JS unit tests.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #66293 (moved)
Edited by Denys Mishunov