Skip to content

Remove usage of gitlab-shell gitlab-keys script

Patrick Bajao requested to merge 60071-remove-gitlab-keys-usage into master

What does this MR do?

Remove the fallback path from gitlab-ce and sets default authorized_keys_file setting.

The default authorized_keys_file setting is the same as gitlab-shell's default. This is to ensure that it's always set.

It needs to be the same as gitlab-shell's default because we don't set a default value in omnibus-gitlab. If users don't set the value of that config in their install and they upgraded, we must ensure that it's still going to point to the same authorized keys file.

gitlab-shell MR to remove gitlab-keys script: gitlab-shell!329 (merged)

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#60071 (closed)

Edited by Patrick Bajao

Merge request reports