Skip to content

Fix forks service

Alex Kalderimis requested to merge fix-forks-service into master

What does this MR do?

During seeing I discovered that the Fork service incorrectly returns the project even if it is in error (persisted but invalid).

This probably indicates bigger problems (we don't want to have persisted invalid records), but it also has the effect of breaking the forks seed job, which raises an error.

This MR ensures that the forks service either succeeds, or does not raise an error.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/66505

Edited by Alex Kalderimis

Merge request reports

Loading