Makes custom Pages domain open as external link in new tab
What does this MR do?
Adds target="_blank" to the custom domain link in Pages which users are expecting to open in a new tab.
Also adds rel="noopener noreferrer" to that link to prevent the newly opened link from gaining access to the window Object of the users GitLab tab. The security issue is further described here: https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/
Edit: After some review, I've also added an external_link haml helper. This way we can quickly add external links (with visual icon) without writing all the boilerplate.
It has the following signature: external_link(body, url, [options])
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #66067 (closed)