Skip to content

Improve search result labels

Markus Koller requested to merge 36383-improve-search-result-labels into master

What does this MR do?

Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/36383

  • Use "results" instead of "blobs", "wiki blobs", "snippet blobs"
    • The same blob can appear more than once, so we decided to use the generic "results"
  • Use "comments" instead of "notes"
  • Use correct pluralization
  • Don't add "1 - 10 of" if there's only one page

Screenshots

Before:

  • image
  • image

After:

  • image
  • image
  • image

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports