Resolve "Forks count do not match after searching"
What does this MR do?
Fixes incorrect fork counts in general and after searching. See https://gitlab.com/gitlab-org/gitlab-ce/issues/66023. The counts do not take search or user access into account anymore. Incorrect counts of starrers were done in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31823.
Because the counts do not take into account user access level anymore, they cannot be used in the HAML view to say 'n private fork(s) you have no access to'. I removed this message and a corresponding test, because I think this is best addressed after the empty state has been fixed (https://gitlab.com/gitlab-org/gitlab-ce/issues/66051) - I can do that, but I don't think there is an illustration for this case yet.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issues
Closes #66023 (closed)