Resolve "Update tooltip of "detached" label/state"
What does this MR do?
Resolves #66061 (closed)
Updates the tooltip of "detached" label/state to say "Pipelines for merge requests are configured. A detached pipeline runs in the context of the merge request, and not against the merged result. Learn more on the documentation for Pipelines for Merged Results."
I would like to share screenshots of how this appears in the tooltip, but I'm currently unsure of how to get my local CE into a state where I can see this label. I would mark as WIP due to not having screenshots, but seeing as how this is a text change I don't want that to be the only reason to delay a merge.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #66061 (closed)
Merge request reports
Activity
changed milestone to %12.3
mentioned in issue #66061 (closed)
This looks great @jakeburden!
To avoid a failed build in EE, would you mind creating a port of this in
gitlab-ee
?Simply apply the same change and open an MR in
gitlab-ee
and link it here. Branch name should beee-66061-update-tooltip-of-detached-label-state
Generally speaking it's good to perform a port from
ce
toee
if you are alteringgitlab.pot
Port made for gitlab-ee https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15306
Thank you, @afontaine !
- Resolved by Jake Burden
@afontaine on the https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15306 port, GitLab Bot is throwing an error because my commits don't start with capital letters. Should I amend my messages on both ee and ce?
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Vitaly Slobodin ( @vitallium
)Clement Ho ( @ClemMakesApps
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖Force pushed a squashed commit with an updated message to better align with the commit message standards
Edited by Jake Burden- Resolved by Clement Ho
@jakeburden this change looks good! Feel free to assign this to an FE maintainer for a final review and merge. (Danger suggests assigning @ClemMakesApps)
- Resolved by Jake Burden
- Resolved by Clement Ho
LGTM, Thanks @jakeburden
enabled an automatic merge when the pipeline for a59c9a13 succeeds
assigned to @ClemMakesApps
mentioned in commit fede390c
- Resolved by Rayana Verissimo
@jakeburden @ClemMakesApps @jhampton This MR didn't receive a UX review. If your merge request includes UX changes 1, it must be approved by a UX team member. Please see: https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines
@jakeburden Please ping me (or Mike) in the MR comments for UX review, not only assign the issue to us, when you're done with the FE. This way we can receive a notification with more details about what needs to be done in the MR. Thanks!