Technical Task

What does this MR do?

@sliaquat

I created a test for root creating a new user: developer-user, as the instruction is to use a specific username I need to add another function that would check if the user exist and delete it.

For the other test 2 to 9, I did not create a test for it as it should already be supported and are covered in the exisiting test additionally I was reading end_to_end/best_practices.md and it says that we do not need to create additional test for user login as it is an expensive task.

Covered in:

2. As a "root" user, create a project. - browser_ui/1_manage/project/create_project_spec.rb

3. Add the "developer-user" user to the project. - browser_ui/1_manage/project/add_project_member_spec.rb

4. As the "developer-user" user, commit a file to the project using SSH in a new branch. - browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb

5. As the "developer-user" user, create a merge request (MR) and assign it to the "root" user for review. - browser_ui/3_create/merge_request/create_merge_request_spec.rb

6. As the "root" user, suggest a change using the "Insert suggestion" button. - browser_ui/2_plan/issue/issue_suggestions_spec.rb

7. As the "developer-user" user, apply the change. - browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb

8. As the "root" user, merge the MR. - browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb

9. As the "root" user, ensure that the repository now has the file with the suggested changes. - browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team