Skip to content

Update file row styling

Illya Klymov requested to merge fix-file-row-styling into master

What does this MR do?

This MR cleans file_row component, so it's styling does not more intervene with other components. This is important as new release of gitlab-ui will introduce change of internal class names for gl-loading-icon, which will break styling here (see gitlab-ui!690 (merged) for details)

We're changing styles so file_row just controls styles of file_icon component, without knowing anything about its implementation details

Screenshot

This also fixes a preexisting issue

Before After
20190819_file_loading_gangsta_lean 20190819_fix_loading_gangsta_lean

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Edited by Paul Slaughter

Merge request reports